MINOR: remove an unused method and adjust method visibility in Utils.java #21398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the safe method that returns an empty list for null input.
chia7712
reviewed
Feb 4, 2026
| * Get the ClassLoader which loaded Kafka. | ||
| */ | ||
| public static ClassLoader getKafkaClassLoader() { | ||
| private static ClassLoader getKafkaClassLoader() { |
Member
There was a problem hiding this comment.
Could we just merge it into getContextOrKafkaClassLoader?
Removed the private method getKafkaClassLoader and replaced its usage.
Contributor
Author
|
Already exposed the method to user with : |
FrankYang0529
approved these changes
Feb 5, 2026
m1a2st
approved these changes
Feb 5, 2026
chia7712
approved these changes
Feb 7, 2026
chia7712
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed safe(List other): This method is not used.
Removed getKafkaClassLoader(): This method was a simple one-line
wrapper. It has been removed, and its logic
(Utils.class.getClassLoader()) has been inlined into
getContextOrKafkaClassLoader() to simplify the code.
Reviewers: PoAn Yang payang@apache.org, Ken Huang
s7133700@gmail.com, Chia-Ping Tsai chia7712@gmail.com